Fix missing logs in UI for tasks in UP_FOR_RETRY state (#54544)#54547
Open
ido177 wants to merge 1 commit intoapache:mainfrom
Open
Fix missing logs in UI for tasks in UP_FOR_RETRY state (#54544)#54547ido177 wants to merge 1 commit intoapache:mainfrom
ido177 wants to merge 1 commit intoapache:mainfrom
Conversation
|
Congratulations on your first Pull Request and welcome to the Apache Airflow community! If you have any issues or are unsure about any anything please check our Contributors' Guide (https://github.com/apache/airflow/blob/main/contributing-docs/README.rst)
|
4aca488 to
c09e533
Compare
ashb
reviewed
Aug 17, 2025
c09e533 to
bf742f5
Compare
bf742f5 to
aeec657
Compare
eladkal
reviewed
Sep 11, 2025
ido177
commented
Sep 17, 2025
93f848d to
70cbf68
Compare
5d1b900 to
22d2777
Compare
22d2777 to
549e679
Compare
Member
|
let's see what CI says |
potiuk
approved these changes
Nov 9, 2025
Member
potiuk
left a comment
There was a problem hiding this comment.
LGTM - but I think other who look at the task logs should take a look. also I think it calls for a unit test.
Member
|
Can you please add unit test @ido177 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
closes: #54544
Fix missing logs in UI for tasks in UP_FOR_RETRY state
Include TaskInstanceState.UP_FOR_RETRY in the log retrieval condition
to ensure logs are shown when a task retries. Previously, tasks that
entered UP_FOR_RETRY had no logs displayed in the UI when using local
log storage.